Attention is currently required from: pespin, fixeria, daniel.

arehbein has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/33198 )

Change subject: stream: Add client-side (segmentation) support for IPA
......................................................................


Patch Set 19:

(1 comment)

Patchset:

PS19:
> So I changed the local port for the stream test from 8967 (previously used) 
> to 8977 and the test ran […]
I just tried

```
log_set_print_timestamp(osmo_stderr_target, 0);
```

in `tests/stream/stream_test.c`

and got an immediate segfault (glanced at the code and I guess it's because the 
logging system isn't initialized by the test, it just uses 
`osmo_gettimeofday()` and custom macros for logging).

I could remove all the time logging instead from the macros defined in the test 
code. If that's what we want.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6
Gerrit-Change-Number: 33198
Gerrit-PatchSet: 19
Gerrit-Owner: arehbein <arehb...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-CC: daniel <dwillm...@sysmocom.de>
Gerrit-CC: fixeria <vyanits...@sysmocom.de>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Attention: fixeria <vyanits...@sysmocom.de>
Gerrit-Attention: daniel <dwillm...@sysmocom.de>
Gerrit-Comment-Date: Fri, 25 Aug 2023 16:02:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein <arehb...@sysmocom.de>
Comment-In-Reply-To: pespin <pes...@sysmocom.de>
Comment-In-Reply-To: daniel <dwillm...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to