Attention is currently required from: arehbein, daniel, fixeria, pespin.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email )
Change subject: stream: Add client-side (segmentation) support for IPA
......................................................................
Patch Set 21:
(1 comment)
Patchset:
PS21:
> Excerpt from current build failure: […]
the actual error is further above in the log:
```
1. testsuite.at:4: testing stream_test ...
./testsuite.at:8: $abs_top_builddir/tests/stream/stream_test
--- expout 2023-09-04 17:53:46.409216560 +0000
+++ /obs/_temp/binpkgs/libosmo-netif/tests/testsuite.dir/at-groups/1/stdout
2023-09-04 17:53:46.637217558 +0000
@@ -169,21 +169,21 @@
{20.625031} [NA|OK] Server's send_last_third_srv(): Sending:[ Last third of
IPAC_MSGT_ID_GET | IPAC_MSGT_PONG | IPAC_MSGT_PONG ]
{20.625031} [NA|OK] Server's send_last_third_srv(): (msg dump: 01 01 00 01
fe 01 00 01 fe 01 )
-{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): [5-cli]
Received message from stream (len = 3)
-{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): msg
buff data: 04 01 01
-{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): IPA
payload: 04 01 01
-{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): Type:
IPAC_MSGT_ID_GET
-{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): (msg
dump (including stripped headers): 00 03 fe 04 01 01 )
-{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): [6-cli]
Received message from stream (len = 1)
-{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): msg
buff data: 01
-{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): IPA
payload: 01
-{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): Type:
IPAC_MSGT_PONG
-{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): (msg
dump (including stripped headers): 00 01 fe 01 )
-{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): [7-cli]
Received message from stream (len = 1)
-{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): msg
buff data: 01
-{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): IPA
payload: 01
-{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): Type:
IPAC_MSGT_PONG
-{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): (msg
dump (including stripped headers): 00 01 fe 01 )
+{20.625576} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): [5-cli]
Received message from stream (len = 3)
+{20.625576} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): msg
buff data: 04 01 01
+{20.625576} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): IPA
payload: 04 01 01
+{20.625576} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): Type:
IPAC_MSGT_ID_GET
+{20.625576} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): (msg
dump (including stripped headers): 00 03 fe 04 01 01 )
+{20.625576} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): [6-cli]
Received message from stream (len = 1)
+{20.625576} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): msg
buff data: 01
+{20.625576} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): IPA
payload: 01
+{20.625576} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): Type:
IPAC_MSGT_PONG
+{20.625576} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): (msg
dump (including stripped headers): 00 01 fe 01 )
+{20.625576} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): [7-cli]
Received message from stream (len = 1)
+{20.625576} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): msg
buff data: 01
+{20.625576} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): IPA
payload: 01
+{20.625576} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): Type:
IPAC_MSGT_PONG
+{20.625576} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): (msg
dump (including stripped headers): 00 01 fe 01 )
==================================Test test_segm_ipa_stream_cli
complete========================================
Stream tests completed
1. testsuite.at:4: 1. stream_test (testsuite.at:4): FAILED (testsuite.at:8)
```
In addition to that, there is a bug in contrib/jenkins.sh: it does not run
"make check" as it is doing in most other Osmocom projects. Otherwise the
testsuite would fail there as well.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6
Gerrit-Change-Number: 33198
Gerrit-PatchSet: 21
Gerrit-Owner: arehbein <arehb...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-CC: daniel <dwillm...@sysmocom.de>
Gerrit-CC: fixeria <vyanits...@sysmocom.de>
Gerrit-CC: osmith <osm...@sysmocom.de>
Gerrit-Attention: arehbein <arehb...@sysmocom.de>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Attention: fixeria <vyanits...@sysmocom.de>
Gerrit-Attention: daniel <dwillm...@sysmocom.de>
Gerrit-Comment-Date: Tue, 05 Sep 2023 09:13:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein <arehb...@sysmocom.de>
Gerrit-MessageType: comment
