Attention is currently required from: dexter, osmith, pespin. keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34150?usp=email )
Change subject: vty: include local port when dumping RTP conns ...................................................................... Patch Set 2: (1 comment) File src/libosmo-mgcp/mgcp_conn.c: https://gerrit.osmocom.org/c/osmo-mgw/+/34150/comment/e81fdaab_0649f848 PS1, Line 373: "rtp:%u<->%u rtcp:%u)", > conn->name contains a number.. example: […] Seeing as how we are not specifying RTCP port in the SDP, that is we adhere to RFC1889 [the corresponding RTCP stream uses the next higher (odd) port number] I'm not sure it makes a lot of sense to take up screen space with this (derivable) data. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34150?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ib89a6779e1d68c6600f00699d4303f6c0ee07132 Gerrit-Change-Number: 34150 Gerrit-PatchSet: 2 Gerrit-Owner: keith <ke...@rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pma...@sysmocom.de> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Attention: osmith <osm...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Attention: dexter <pma...@sysmocom.de> Gerrit-Comment-Date: Thu, 14 Sep 2023 07:29:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: keith <ke...@rhizomatica.org> Comment-In-Reply-To: dexter <pma...@sysmocom.de> Gerrit-MessageType: comment
