Attention is currently required from: dexter, keith, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34150?usp=email )
Change subject: vty: include local port when dumping RTP conns ...................................................................... Patch Set 2: (1 comment) File src/libosmo-mgcp/mgcp_conn.c: https://gerrit.osmocom.org/c/osmo-mgw/+/34150/comment/83bcd00e_e5ce91aa PS1, Line 373: "rtp:%u<->%u rtcp:%u)", > Seeing as how we are not specifying RTCP port in the SDP, that is we adhere > to RFC1889 [the correspo […] I'm totally fine with dropping the rtcp part. In any case, please add the "l:<->r:" prefixes as I suggested, otherwise it becomes confusing trying to figure out which IP is the remote and which the local one. It may seem obvious if you are the operator, but usually the case is that someone else is looking at the logs without direct access or knowledge of the network. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34150?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ib89a6779e1d68c6600f00699d4303f6c0ee07132 Gerrit-Change-Number: 34150 Gerrit-PatchSet: 2 Gerrit-Owner: keith <ke...@rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pma...@sysmocom.de> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Attention: osmith <osm...@sysmocom.de> Gerrit-Attention: keith <ke...@rhizomatica.org> Gerrit-Attention: dexter <pma...@sysmocom.de> Gerrit-Comment-Date: Thu, 14 Sep 2023 11:28:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: keith <ke...@rhizomatica.org> Comment-In-Reply-To: dexter <pma...@sysmocom.de> Gerrit-MessageType: comment
