Attention is currently required from: fixeria, pespin.

falconia has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/34449?usp=email )

Change subject: SMS over GSUP: implement forwarding of MO SMS
......................................................................


Patch Set 2:

(1 comment)

File src/hlr_sms.c:

https://gerrit.osmocom.org/c/osmo-hlr/+/34449/comment/74848ad9_36c827cf
PS2, Line 136:  char smsc_addr[21];
> Adding `libsmpp34` dependency is indeed not a good idea, given that osmo-hlr 
> has nothing to to with  […]
libosmocore header addition:

https://gerrit.osmocom.org/c/libosmocore/+/34456



--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/34449?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Iaad4531922c41583d261c79f42561a1bdbe03521
Gerrit-Change-Number: 34449
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <fal...@freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Attention: fixeria <vyanits...@sysmocom.de>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Mon, 18 Sep 2023 19:37:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <fal...@freecalypso.org>
Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de>
Comment-In-Reply-To: pespin <pes...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to