Attention is currently required from: falconia, fixeria, pespin.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/34449?usp=email )

Change subject: SMS over GSUP: implement forwarding of MO SMS
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

File src/hlr_sms.c:

https://gerrit.osmocom.org/c/osmo-hlr/+/34449/comment/674a918b_92afd891
PS2, Line 136:  char smsc_addr[21];
> Ah I thought libsmpp34 was already used but I was probably confused with 
> osmo-msc. […]
I just merged the libosmocore header addition.



--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/34449?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Iaad4531922c41583d261c79f42561a1bdbe03521
Gerrit-Change-Number: 34449
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <fal...@freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Attention: falconia <fal...@freecalypso.org>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Attention: fixeria <vyanits...@sysmocom.de>
Gerrit-Comment-Date: Tue, 19 Sep 2023 10:42:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: falconia <fal...@freecalypso.org>
Comment-In-Reply-To: pespin <pes...@sysmocom.de>
Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to