Attention is currently required from: falconia, fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/34448?usp=email )
Change subject: SMS over GSUP: implement vty config of SMSC routing ...................................................................... Patch Set 2: (1 comment) File include/osmocom/hlr/hlr_sms.h: https://gerrit.osmocom.org/c/osmo-hlr/+/34448/comment/e545f39c_99bae55a PS2, Line 17: void smsc_del(struct hlr_smsc *smsc); > Removing from llist is in general fine instead the _free function too, you > can see plenty of example […] I think we need to differntiate between a) a pure "foo_free" function which primarily is a about releasing memory b) some function that does more additional work, where e.g. a route is added or deleted. in that case add+del is fine. Now the problem starts to be problematic if we have "alloc" on the creation side and "del" on the release side. That really just looks wrong. so either it's add+del, or it's alloc+free. strictly speaking, an "alloc" function should not add it to a list, and a free function shouldn'd delete it. So either you have add/del doing the alloc/free automagically, or you have orthogonal alloc -> add -> del -> free functions. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/34448?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I1624dcd9d22b4efca965ccdd1c74f0063a94a33c Gerrit-Change-Number: 34448 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <fal...@freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: falconia <fal...@freecalypso.org> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Comment-Date: Tue, 19 Sep 2023 10:40:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <fal...@freecalypso.org> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Gerrit-MessageType: comment