Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34532?usp=email )
Change subject: rlcmac: Fix compilation error 'rlcmac_prim may be used uninitialized' ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/libosmo-gprs/+/34532/comment/9e4a21bf_60933ab1 PS1, Line 7: error > Is it really an error? Or a warning that becomes an error when building with > `--disable-werror`? Done File src/rlcmac/tbf_ul_ass_fsm.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/34532/comment/43e99161_34d8904c PS1, Line 121: default > For the record: I intentionally did not add the `default` branch, because I > expected that a warning […] In this case, I can understand the compilation warning because one can still possibly add whatever uint value you want to that variable. So it's actually possible that it contains any other value and hence rlcmac_prim indeed ends up being uninitialized after the switch This is really a fix. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34532?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ica93447bc1f2e60984be7c9c73b153b4eb508aaa Gerrit-Change-Number: 34532 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Comment-Date: Tue, 26 Sep 2023 12:54:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Gerrit-MessageType: comment
