Attention is currently required from: pespin.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-gprs/+/34532?usp=email )

Change subject: rlcmac: Fix compilation error 'rlcmac_prim may be used 
uninitialized'
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

File src/rlcmac/tbf_ul_ass_fsm.c:

https://gerrit.osmocom.org/c/libosmo-gprs/+/34532/comment/d99e3269_e3952b72
PS1, Line 121: default
> For the record: I intentionally did not add the `default` branch, because I 
> expected that a warning  […]
Perhaps the following like triggers the compiler:

```
ctx->ass_type = *(enum gprs_rlcmac_tbf_ul_ass_type *)data;
```



--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34532?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: Ica93447bc1f2e60984be7c9c73b153b4eb508aaa
Gerrit-Change-Number: 34532
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Tue, 26 Sep 2023 12:55:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to