Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34967?usp=email )
Change subject: tests: Test gsmtap logging if write queue fills up ...................................................................... Patch Set 1: (3 comments) File tests/logging/logging_test_gsmtap.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12292): https://gerrit.osmocom.org/c/libosmocore/+/34967/comment/e654eaaf_92b1cc35 PS1, Line 57: for (int i = 0; i < 200; i++) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12292): https://gerrit.osmocom.org/c/libosmocore/+/34967/comment/7f9350c7_afc521ec PS1, Line 58: DEBUGP(DLGLOBAL, "Repeating message (i = %i)\n", i); Use %d instead of %i Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12292): https://gerrit.osmocom.org/c/libosmocore/+/34967/comment/f3c2cda0_9a241246 PS1, Line 61: for (int i = 0; i < 200; i++) { braces {} are not necessary for single statement blocks -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34967?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id5ae0c4c3820a9ed59eaf4003d2c57b6bdfe3468 Gerrit-Change-Number: 34967 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillm...@sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 03 Nov 2023 20:23:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
