Attention is currently required from: fixeria.

daniel has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/34967?usp=email )

Change subject: tests: Test gsmtap logging if write queue fills up
......................................................................


Patch Set 2:

(1 comment)

File tests/logging/logging_test_gsmtap.err:

https://gerrit.osmocom.org/c/libosmocore/+/34967/comment/d158b54a_45ea80e2 
PS2, Line 108: 0x611000000328
> this is non-deterministic output, we should not match it
Yeah, do you see any other way of removing such information without changing 
the log message?
Do we need a name in osmo_wqueue (and default to %p) so we can print that?



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34967?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id5ae0c4c3820a9ed59eaf4003d2c57b6bdfe3468
Gerrit-Change-Number: 34967
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arehbein <arehb...@sysmocom.de>
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Attention: fixeria <vyanits...@sysmocom.de>
Gerrit-Comment-Date: Thu, 30 Nov 2023 13:39:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to