Attention is currently required from: Hoernchen. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/36377?usp=email )
Change subject: ms: disabe uhd ms build ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File Transceiver52M/Makefile.am: https://gerrit.osmocom.org/c/osmo-trx/+/36377/comment/90c673ee_969bd621 PS1, Line 130: #if ENABLE_MS_TRX might be worth adding a reason in a comment here, not just in the commit log. This way a potential future reader of the file knows why it is disabled without having to go to git blame or git log. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36377?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I9db1740b5c399a02a41b1d07792c645cf7d1bd1b Gerrit-Change-Number: 36377 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ew...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Attention: Hoernchen <ew...@sysmocom.de> Gerrit-Comment-Date: Fri, 22 Mar 2024 07:30:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment