Attention is currently required from: laforge.

Hoernchen has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/36377?usp=email )

Change subject: ms: disabe uhd ms build
......................................................................


Patch Set 1:

(1 comment)

File Transceiver52M/Makefile.am:

https://gerrit.osmocom.org/c/osmo-trx/+/36377/comment/ddb3addf_e18c010c
PS1, Line 130: #if ENABLE_MS_TRX
> might be worth adding a reason in a comment here, not just in the commit log. 
> […]
I am not a fan of duplicating VCS information, modern IDEs will show the commit 
messages anyway, and multiple levels of blame are just one click away...



--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36377?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I9db1740b5c399a02a41b1d07792c645cf7d1bd1b
Gerrit-Change-Number: 36377
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ew...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Attention: laforge <lafo...@osmocom.org>
Gerrit-Comment-Date: Fri, 22 Mar 2024 10:26:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <lafo...@osmocom.org>
Gerrit-MessageType: comment

Reply via email to