Attention is currently required from: fixeria, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36538?usp=email )
Change subject: add osmo_stats_report_lock api ...................................................................... Patch Set 2: (4 comments) File src/core/stats.c: https://gerrit.osmocom.org/c/libosmocore/+/36538/comment/f1b71d2e_9e393292 PS1, Line 794: * Calling osmo_stats_report_use_lock(true) */ > unfinished comment Done https://gerrit.osmocom.org/c/libosmocore/+/36538/comment/fc865170_26d7a750 PS1, Line 808: pthread_mutex_destroy(g_report_lock); > good point Done https://gerrit.osmocom.org/c/libosmocore/+/36538/comment/4d11a8c8_85346f55 PS1, Line 819: void osmo_stats_report_lock(bool lock) > easier to trace: good point Done https://gerrit.osmocom.org/c/libosmocore/+/36538/comment/4c0f763b_cf3baf1b PS1, Line 831: pthread_mutex_t *lock = g_report_lock; > I remember now, it was a useless precaution against a changing g_report_lock. > […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36538?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib335bea7d2a440ca284e6c439066f96456bf2c2d Gerrit-Change-Number: 36538 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 09 Apr 2024 03:45:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofm...@sysmocom.de> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
