Attention is currently required from: fixeria, laforge, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36538?usp=email )
Change subject: add osmo_stats_report_lock api ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: > I wonder why after all the discussions around atomic counters you decided to > go with the presumably […] And for the case at hand, I still belive it makes much more sense to simply use an osmo_itq to pass the related updated counters every X seconds. The fact that the counter is atomic doesn't help with the fact that you still need to access objects which are in a llist which may be changing over time. So let's avoid problems, imho use an osmo_itq there and simply abandon this patch as we don't really need it now. File src/core/stats.c: https://gerrit.osmocom.org/c/libosmocore/+/36538/comment/b0a94212_a2dda1f5 PS2, Line 791: static pthread_mutex_t *g_report_lock = NULL; > just a thought, it would be far simpler to only publish this pointer on > public API. […] I think having APIs is better, it allows changing the implementation later on to whatever else. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36538?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib335bea7d2a440ca284e6c439066f96456bf2c2d Gerrit-Change-Number: 36538 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: neels <nhofm...@sysmocom.de> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Comment-Date: Tue, 09 Apr 2024 08:50:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofm...@sysmocom.de> Comment-In-Reply-To: laforge <lafo...@osmocom.org> Gerrit-MessageType: comment
