Attention is currently required from: daniel, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37864?usp=email )
Change subject: Add Routing Areas ...................................................................... Patch Set 12: (8 comments) File include/osmocom/sgsn/gprs_routing_area.h: https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/15278811_b87a499b?usp=email : PS9, Line 19: ras > ra_list Acknowledged https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/530260da_73889357?usp=email : PS9, Line 19: ras > ra_list Done https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/5629afcf_e19c505c?usp=email : PS9, Line 32: /* contains cells which are in BVC_UNBLOCKED */ > Not sure what you mean here. […] Acknowledged https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/373acf3c_b6a34518?usp=email : PS9, Line 32: /* contains cells which are in BVC_UNBLOCKED */ > Not sure what you mean here. […] Done File src/sgsn/gprs_routing_area.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/dc7b4f4c_0a5cdfef?usp=email : PS5, Line 45: if (!drop_empty_ra) { > I'll remove empty RoutingAreas for now Done https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/614db4c2_54e3679f?usp=email : PS5, Line 281: } > All this function is also a bit cumbersome, I encourage doing a second > thought too. Done File src/sgsn/gprs_routing_area.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/3952621a_a96c5b73?usp=email : PS9, Line 235: /* FIXME: drop old BVCI? How to handle the same RAI/CellId via different BVCIs? */ > Yeah, I would drop the old one. […] I'm keeping for now the old one and replacing it's parameters, because removing doesn't do anything at the moment. https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/baff9589_cee4a0db?usp=email : PS9, Line 237: LOGP(DRA, LOGL_INFO, "GERAN Cell changed DLCI. Old: nsei/bvci 0x%04x/0x%04x New: nsei/bvci 0x%04x/0x%04x\n", > gbproxy uses %05u, ns2 uses %d, sometimes %u and other times %05u […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37864?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I2474b19a7471a1dea3c863ddf8372b16180211aa Gerrit-Change-Number: 37864 Gerrit-PatchSet: 12 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-CC: osmith <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: daniel <[email protected]> Gerrit-Comment-Date: Mon, 23 Sep 2024 20:50:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: daniel <[email protected]> Comment-In-Reply-To: lynxis lazus <[email protected]>
