Attention is currently required from: daniel, lynxis lazus.

fixeria has posted comments on this change by lynxis lazus. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/37864?usp=email )

Change subject: Add Routing Areas
......................................................................


Patch Set 15:

(1 comment)

File tests/testsuite.at:

https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/21760efe_2f965942?usp=email
 :
PS15, Line 21: ignore
> I tend to use stderr for output meant for humans, which can also contain 
> random data.
But in this specific case the stderr contains logging generated by test. It 
might be a good idea to match at least the `DRA` related logging here. We don't 
seem to be doing this here in osmo-sgsn, but we do in other projects (e.g. 
https://cgit.osmocom.org/osmo-bts/tree/tests/power/ms_power_loop_test.err).



--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37864?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I2474b19a7471a1dea3c863ddf8372b16180211aa
Gerrit-Change-Number: 37864
Gerrit-PatchSet: 15
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: fixeria <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-CC: osmith <[email protected]>
Gerrit-Attention: daniel <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Comment-Date: Wed, 09 Oct 2024 22:07:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>
Comment-In-Reply-To: lynxis lazus <[email protected]>

Reply via email to