Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434?usp=email )
Change subject: bl updater app ...................................................................... Patch Set 7: (2 comments) File atmel_start.c: https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/5512c35c_36a35800?usp=email : PS7, Line 9: // do not init usb here: might not be needed. might be useful to state those cases or some example of it? File usb_dfu_main.c: https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/3807f4ce_9e4c9d6d?usp=email : PS7, Line 59: } inconsistent spacing. File is not generated code, uses tab indent but here there are suddenly some lines with spaces. -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I1403d35497cdea41ea5bed2c94b9e729ca352772 Gerrit-Change-Number: 39434 Gerrit-PatchSet: 7 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <[email protected]> Gerrit-Attention: Hoernchen <[email protected]> Gerrit-Comment-Date: Thu, 30 Jan 2025 12:27:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
