Attention is currently required from: laforge.

Hoernchen has posted comments on this change by Hoernchen. ( 
https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434?usp=email )

Change subject: bl updater app
......................................................................


Patch Set 11:

(1 comment)

File atmel_start.c:

https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/8470664b_844aa75f?usp=email
 :
PS7, Line 9:    // do not init usb here: might not be needed.
> might be useful to state those cases or some example of it?
the original bl would have required a comment that justifies why it attaches to 
the bus for no reason and hopes the firmware starts fast enough. this behaves 
as expected, the bootloader just.. bootloads all the things, there is no usb 
invovled.



--
To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-asf4-dfu
Gerrit-Branch: master
Gerrit-Change-Id: I1403d35497cdea41ea5bed2c94b9e729ca352772
Gerrit-Change-Number: 39434
Gerrit-PatchSet: 11
Gerrit-Owner: Hoernchen <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Wed, 12 Mar 2025 12:19:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>

Reply via email to