Attention is currently required from: fixeria, laforge. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41189?usp=email )
Change subject: MME-Tests: Add test for emergency bearer setup ...................................................................... Patch Set 3: (5 comments) File mme/ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41189/comment/3def325b_a9c4730f?usp=email : PS2, Line 393: var charstring apn := char(0, 0, 0, 4) & "test" & char(0, 0, 0, 3) & "sos"; > actually, this should probably simply use `f_dns_enc_label("test. […] Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41189/comment/e1f5c0cd_f9c258bb?usp=email : PS2, Line 947: Request > Request or Success? The altstep name suggests the later. the altstep expects tr_GTP2C_CreateSessionReq and replies with ts_GTP2C_CreateSessionResp. so "Request" is the what we expect. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41189/comment/606020ae_ee5ca266?usp=email : PS2, Line 952: log2str > `log2str` not really needed here. Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41189/comment/3893a1b7_dbb8c148?usp=email : PS2, Line 955: .start > You're re-using a timer that may already be running. […] Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41189/comment/0e90c806_dd39e57f?usp=email : PS2, Line 958: log2str > `log2str` not really needed here. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41189?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2a81defc96bcebdf1a4ec765278ca502800cbe46 Gerrit-Change-Number: 41189 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Thu, 02 Oct 2025 14:01:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: fixeria <[email protected]>
