Attention is currently required from: jolly.

fixeria has posted comments on this change by jolly. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41189?usp=email )

Change subject: MME-Tests: Add test for emergency bearer setup
......................................................................


Patch Set 2:

(4 comments)

File mme/ConnHdlr.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41189/comment/4a8cabe6_e7143b16?usp=email
 :
PS2, Line 947: Request
Request or Success? The altstep name suggests the later.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41189/comment/8236d672_27120f7f?usp=email
 :
PS2, Line 952: log2str
`log2str` not really needed here.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41189/comment/67945095_bb86142e?usp=email
 :
PS2, Line 955: .start
You're re-using a timer that may already be running.
Either do `T.stop` before starting it again, or use a different timer.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41189/comment/6109fc00_4d63f77e?usp=email
 :
PS2, Line 958: log2str
`log2str` not really needed here.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41189?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2a81defc96bcebdf1a4ec765278ca502800cbe46
Gerrit-Change-Number: 41189
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: jolly <[email protected]>
Gerrit-Comment-Date: Wed, 01 Oct 2025 16:32:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to