Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/41138?usp=email )
Change subject: Correctly calculate size iofd_msgb_alloc2() ...................................................................... Patch Set 2: Code-Review-1 (1 comment) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/41138/comment/42e0bfdf_55a2a702?usp=email : PS2, Line 193: return msgb_alloc_headroom_c(iofd, size + headroom, headroom, "osmo_io_msgb"); static inline struct msgb *msgb_alloc_headroom_c(const void *ctx, uint16_t size, uint16_t headroom, const char *name) See uint16_t size above, this is broken anyway when passing "size+headroom". -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41138?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I16c1e08fb64a1fafaeee1844fd8c00ecc2861d12 Gerrit-Change-Number: 41138 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Comment-Date: Sat, 11 Oct 2025 19:51:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
