Attention is currently required from: laforge, pespin.

jolly has posted comments on this change by jolly. ( 
https://gerrit.osmocom.org/c/libosmocore/+/41138?usp=email )

Change subject: Correctly calculate size iofd_msgb_alloc2()
......................................................................


Patch Set 2:

(1 comment)

File src/core/osmo_io.c:

https://gerrit.osmocom.org/c/libosmocore/+/41138/comment/e92cfa28_468701a5?usp=email
 :
PS2, Line 193:  return msgb_alloc_headroom_c(iofd, size + headroom, headroom, 
"osmo_io_msgb");
> static inline struct msgb *msgb_alloc_headroom_c(const void *ctx, uint16_t 
> size, uint16_t headroom,  […]
I used some casting to make it clearer that there can't be an overflow.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41138?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I16c1e08fb64a1fafaeee1844fd8c00ecc2861d12
Gerrit-Change-Number: 41138
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Mon, 27 Oct 2025 11:08:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>

Reply via email to