Attention is currently required from: dexter. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41448?usp=email )
Change subject: card_key_provider: add unit-test ...................................................................... Patch Set 1: (2 comments) File tests/unittests/test_card_key_provider.py: https://gerrit.osmocom.org/c/pysim/+/41448/comment/63cea0c8_66d384fa?usp=email : PS1, Line 68: if result != t.get('EXPECTED'): : print("\nexpected: ", t.get('EXPECTED'), " for ICCID:", t.get('ICCID'), "\ngot:", result) : self.assertTrue(False) : ```suggestion self.assertEqual(result, t.get('EXPECTED')) ``` https://gerrit.osmocom.org/c/pysim/+/41448/comment/85be7056_d75fa882?usp=email : PS1, Line 79: if result != t.get('EXPECTED'): : print("\nexpected: ", t.get('EXPECTED'), " for ICCID:", t.get('ICCID'), "\ngot:", result) : ```suggestion self.assertEqual(result, t.get('EXPECTED')) ``` -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41448?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I52519847a4c4a13a7bca49985133872b01c4aaab Gerrit-Change-Number: 41448 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Tue, 18 Nov 2025 13:48:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
