Attention is currently required from: fixeria.

dexter has posted comments on this change by dexter. ( 
https://gerrit.osmocom.org/c/pysim/+/41448?usp=email )

Change subject: card_key_provider: add unit-test
......................................................................


Patch Set 3:

(2 comments)

File tests/unittests/test_card_key_provider.py:

https://gerrit.osmocom.org/c/pysim/+/41448/comment/fd3b5f5d_d6280b65?usp=email :
PS1, Line 68:             if result != t.get('EXPECTED'):
            :                 print("\nexpected: ", t.get('EXPECTED'), " for 
ICCID:", t.get('ICCID'), "\ngot:", result)
            :                 self.assertTrue(False)
            :
> ```suggestion […]
Done


https://gerrit.osmocom.org/c/pysim/+/41448/comment/394654d3_39b0b359?usp=email :
PS1, Line 79:             if result != t.get('EXPECTED'):
            :                 print("\nexpected: ", t.get('EXPECTED'), " for 
ICCID:", t.get('ICCID'), "\ngot:", result)
            :
> ```suggestion […]
Done



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/41448?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I52519847a4c4a13a7bca49985133872b01c4aaab
Gerrit-Change-Number: 41448
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Tue, 18 Nov 2025 14:42:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>

Reply via email to