Attention is currently required from: laforge, lynxis lazus, pespin. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email )
Change subject: Add TCAP based loadsharing/routing ...................................................................... Patch Set 13: (9 comments) File src/ss7_as_loadshare_tcap.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/c45ed608_c0c6707e?usp=email : PS8, Line 379: /* FIXME: use UTDS */ > It's used in asp_loadshare_tcap_sccp. @lynxis@fe80. […] Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/ae615bae_c7973fe0?usp=email : PS8, Line 380: static int sent_back_utds(struct osmo_ss7_as *as, > I need to investigate about this: […] Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/d3c146a8_ba6b0ac9?usp=email : PS8, Line 473: * \return > return is not described. Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/fef52002_7171fa11?usp=email : PS8, Line 475: static int asp_loadshare_tcap_sccp(struct osmo_ss7_asp **rasp, struct osmo_ss7_as *as, uint32_t opc, uint32_t dpc, > imho the EPROTONOSUPPORT should be dropped, and return rasp instead. Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/d2ccee28_39577526?usp=email : PS8, Line 560: sent_back_utds(as, xua, sua, SCCP_RETURN_CAUSE_SUBSYSTEM_FAILURE); > I need to investigate about this: […] Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/6fe54d5c_ad73952e?usp=email : PS8, Line 607: * @return 0 on success > afaiu this should only return the asp, no need to return an rc? Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/c8996526_0b1472fb?usp=email : PS8, Line 921: /** Called when the ASP is going down or free'd > Why? Done File src/ss7_asp.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/1d29a837_b822b858?usp=email : PS8, Line 1216: tcap_asp_down(asp); > nooo way you are calling this here. Put it where it belongs in the FSM. Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/602f6632_cb2af21b?usp=email : PS8, Line 1344: tcap_asp_down(asp); > I can have a look. Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d Gerrit-Change-Number: 41309 Gerrit-PatchSet: 13 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: daniel <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Comment-Date: Thu, 27 Nov 2025 17:24:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: daniel <[email protected]> Comment-In-Reply-To: lynxis lazus <[email protected]>
