Attention is currently required from: daniel, laforge, lynxis lazus, pespin.

osmith has posted comments on this change by lynxis lazus. ( 
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email )

Change subject: Add TCAP based loadsharing/routing
......................................................................


Patch Set 16:

(1 comment)

File tests/vty/Makefile.am:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/4ff0cc59_8db59333?usp=email
 :
PS15, Line 35:                  ss7_asp_test.vty \
> This is still wrong, but I don't think it explains the build failures in the 
> jenkins job. […]
this fixes it:

```diff
diff --git a/tests/vty/Makefile.am b/tests/vty/Makefile.am
index 2d2ff87..ce96380 100644
--- a/tests/vty/Makefile.am
+++ b/tests/vty/Makefile.am
@@ -46,7 +46,7 @@ vty-transcript-test-stp: $(top_builddir)/stp/osmo-stp
        osmo_verify_transcript_vty.py -v \
                -n OsmoSTP -p 4239 \
                -r "$(top_builddir)/stp/osmo-stp -c 
$(top_srcdir)/doc/examples/osmo-stp-multihome.cfg" \
-               $(U) $(srcdir)/$(VTY_TEST_STP)
+               $(U) $(patsubst %,$(srcdir)/%,$(VTY_TEST_STP))

 # Run a specific test with: 'make vty-test VTY_TEST_ASP=ss7_asp_test.vty'
 VTY_TEST_ASP ?= ss7_asp_*.vty
 ```



--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d
Gerrit-Change-Number: 41309
Gerrit-PatchSet: 16
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: daniel <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-CC: osmith <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: daniel <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Comment-Date: Mon, 01 Dec 2025 14:33:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: daniel <[email protected]>

Reply via email to