lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/pysim/+/41581?usp=email )


Change subject: ts_31_102: EF SUCI_Calc_Info: fix decoding empty files
......................................................................

ts_31_102: EF SUCI_Calc_Info: fix decoding empty files

When trying to use `edit_binary_decoded` with an empty file, pysim
runs into a len(None) exception, because hpkl.to_dict()['hnet_pubkey_list'] 
returns
None.

Can reproduced with a CCC Camp 2023 usim and editing the file.

Change-Id: Ib8e322e65dd768bfd49e7a5620a2163f12a74ec7
---
M pySim/ts_31_102.py
1 file changed, 4 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/81/41581/1

diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py
index 4ee6621..1f46241 100644
--- a/pySim/ts_31_102.py
+++ b/pySim/ts_31_102.py
@@ -389,7 +389,10 @@
         # remaining data holds Home Network Public Key Data Object
         hpkl = EF_SUCI_Calc_Info.HnetPubkeyList()
         hpkl.from_tlv(in_bytes[pos:])
-        hnet_pubkey_list = 
self._compact_pubkey_list(hpkl.to_dict()['hnet_pubkey_list'])
+
+        hnet_pubkey_list = []
+        if hpkl.to_dict()['hnet_pubkey_list']:
+            hnet_pubkey_list = 
self._compact_pubkey_list(hpkl.to_dict()['hnet_pubkey_list'])

         return {
             'prot_scheme_id_list': prot_scheme_id_list,

--
To view, visit https://gerrit.osmocom.org/c/pysim/+/41581?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ib8e322e65dd768bfd49e7a5620a2163f12a74ec7
Gerrit-Change-Number: 41581
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <[email protected]>

Reply via email to