Attention is currently required from: lynxis lazus.

laforge has posted comments on this change by lynxis lazus. ( 
https://gerrit.osmocom.org/c/pysim/+/41581?usp=email )

Change subject: ts_31_102: EF SUCI_Calc_Info: fix decoding empty files
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

File pySim/ts_31_102.py:

https://gerrit.osmocom.org/c/pysim/+/41581/comment/665b251f_da76d648?usp=email :
PS1, Line 392:         hnet_pubkey_list = 
self._compact_pubkey_list(hpkl.to_dict()['hnet_pubkey_list'])
wouldn't something more compact work without interrupting the cotrol flow of 
the source / indent / ...?
```
     hnet_pubkey_list = 
self._compact_pubkey_list(hpkl.to_dict()['hnet_pubkey_list'] or [])
```



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/41581?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ib8e322e65dd768bfd49e7a5620a2163f12a74ec7
Gerrit-Change-Number: 41581
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Comment-Date: Tue, 09 Dec 2025 14:11:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to