Attention is currently required from: jolly, tnt. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-e1d/+/41139?usp=email )
Change subject: Add Channel-Associated Signalling (CAS) support ...................................................................... Patch Set 3: -Code-Review (1 comment) File src/mux_demux.c: https://gerrit.osmocom.org/c/osmo-e1d/+/41139/comment/e58f2b6e_6d5de452?usp=email : PS3, Line 397: if (!line->cas.rx.buf_valid[line->cas.rx.frame_count + 14] || this looks to me like the event is signalled at a per-line level, and not at a per-timeslot level. IMHO, the comparison should be iterating over the timeslots and for each timeslot comparing the 4 past CAS bits of one timeslot with the 4 current/new CAS bits and then indicate a signal for the specific timeslot. Basically, nothing in a client should relate to the entire line, everything should happen at a per-timeslot level. Of course one could keep the signal in the protocol at a line-level and then have the libosmo-e1d client code figure out the affected timeslots and signal those in the application. But any application that holds open any timeslot within the line should get that notification. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/41139?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ib4f5e6ef02c9b0d1eec2a86d9c48376112805972 Gerrit-Change-Number: 41139 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: tnt <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Attention: tnt <[email protected]> Gerrit-Comment-Date: Mon, 05 Jan 2026 12:51:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
