Attention is currently required from: jolly, tnt.

pespin has posted comments on this change by jolly. ( 
https://gerrit.osmocom.org/c/osmo-e1d/+/41139?usp=email )

Change subject: Add Channel-Associated Signalling (CAS) support
......................................................................


Patch Set 3:

(2 comments)

File include/osmocom/e1d/proto_clnt.h:

https://gerrit.osmocom.org/c/osmo-e1d/+/41139/comment/6a907233_2071e31c?usp=email
 :
PS3, Line 47: int osmo_e1dp_client_set_cas(struct osmo_e1dp_client *clnt, 
uint8_t intf, uint8_t line, uint8_t ts,
Update TODO-RELEASE with an entry stating a new API is added.


File src/ctl.c:

https://gerrit.osmocom.org/c/osmo-e1d/+/41139/comment/f4ab51f8_056fea00?usp=email
 :
PS3, Line 382:  if (line->ts[16].mode == E1_TS_MODE_CAS && hdr->ts == 16) {
maybe not important, but sounds safer first checking hdr->ts and then accessing 
line->ts.



--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/41139?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: Ib4f5e6ef02c9b0d1eec2a86d9c48376112805972
Gerrit-Change-Number: 41139
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: tnt <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: jolly <[email protected]>
Gerrit-Attention: tnt <[email protected]>
Gerrit-Comment-Date: Wed, 07 Jan 2026 11:20:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to