Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-bts/+/41807?usp=email )
Change subject: {bs,ms}_power_control: Move params inside lchan_power_ctrl_state
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
I would like to review this patch more carefully when I am back from vacation
(next week), so please don't rush merging it. So far I had a quick look and I
don't really understand/see what do we benefit from this refactoring.
>From what I remember, I intentionally wanted to have the power control
>parameters separated from the power control state. And using the pointer
>allows to avoid memcpy()ing parameters which are identical for all lchans in
>99% cases. I don't see how this pointer being `NULL` can crate problems in
>static mode: one shall simply never need to access dynamic power control
>parameters in static mode.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41807?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I0e2a6c2c33e0ac9a0bc1734d83eaeafc27f2f4df
Gerrit-Change-Number: 41807
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Fri, 09 Jan 2026 14:10:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
