Attention is currently required from: fixeria.
pespin has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-bts/+/41807?usp=email )
Change subject: {bs,ms}_power_control: Move params inside lchan_power_ctrl_state
......................................................................
Patch Set 3:
(2 comments)
File src/common/power_control.c:
https://gerrit.osmocom.org/c/osmo-bts/+/41807/comment/bb13e55f_9df929f1?usp=email
:
PS3, Line 343: memcpy(params, trx->ms_dpc_params, sizeof(*params));
> And you say pointers are the source of bugs... […]
Done
File src/common/rsl.c:
https://gerrit.osmocom.org/c/osmo-bts/+/41807/comment/f64a9457_afbac29c?usp=email
:
PS3, Line 2082: lchan->ms_power_ctrl.dpc_enabled = true;
> ```suggestion […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41807?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I0e2a6c2c33e0ac9a0bc1734d83eaeafc27f2f4df
Gerrit-Change-Number: 41807
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Mon, 12 Jan 2026 10:23:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>
