Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40096?usp=email )
Change subject: personalization: add param_source.py, implement batch personalization ...................................................................... Patch Set 8: (1 comment) Patchset: PS6: > I apologize if they have they been marked as resolved in error. […] I think we have had this discussion in the osmocom community before, and the general social consensus is to avoid pushing branches to "probe build status". Usually (pysim is different due to the tests with physical cards not available locally) the local execution of `./contrib/jenkins.sh` can be used for that. The rationale is that every reviewer will get notified about the new patch version, open it, look at it, and then only to discover that the last feedback has not been adressed in the code, nor has there been any comment from the author why it has not been adressed. So yes, it may happen occasionally that builds fail unexpectedly, or having overlooked some review comments. But IMHO we should generally avoid pushing changes *knowing* that some review is still pending being adressed. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40096?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I497c60c101ea0eea980e8b1a4b1f36c0eda39002 Gerrit-Change-Number: 40096 Gerrit-PatchSet: 8 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Comment-Date: Sun, 11 Jan 2026 15:31:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <[email protected]> Comment-In-Reply-To: laforge <[email protected]>
