Attention is currently required from: laforge.

neels has posted comments on this change by neels. ( 
https://gerrit.osmocom.org/c/pysim/+/40096?usp=email )

Change subject: personalization: add param_source.py, implement batch 
personalization
......................................................................


Patch Set 8:

(3 comments)

File pySim/esim/saip/param_source.py:

https://gerrit.osmocom.org/c/pysim/+/40096/comment/770a282b_008ad68b?usp=email :
PS3, Line 33: abstract
> plug here the same conclusion i formed about the other is_abstract flag. […]
Done


https://gerrit.osmocom.org/c/pysim/+/40096/comment/8d6da696_1f0fd0b1?usp=email :
PS3, Line 132: RandomDigitSource
> ack
Done


https://gerrit.osmocom.org/c/pysim/+/40096/comment/41ec6dc4_2a00211f?usp=email :
PS3, Line 133:     'incrementing sequence of digits'
> (i never got over it, python used to be so single-quote-y, but at some point 
> linters started making  […]
Done



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/40096?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I497c60c101ea0eea980e8b1a4b1f36c0eda39002
Gerrit-Change-Number: 40096
Gerrit-PatchSet: 8
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Thu, 15 Jan 2026 02:33:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <[email protected]>
Comment-In-Reply-To: laforge <[email protected]>

Reply via email to