Attention is currently required from: Timur Davydov.

laforge has posted comments on this change by Timur Davydov. ( 
https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email )

Change subject: Add Emscripten build support and JS callback logging backend
......................................................................


Patch Set 5:

(1 comment)

Patchset:

PS5:
While I'm personally not a big believer in the "let's run SDR software and/or 
telecom protocol stacks in the browser" approach, I think the patch is 
reasonably clean and hence there is not really any argument against it.

However, what I would like to see is some kind of build verification for 
emscripten in our jenkins, so we make sure we don't accidentially break the 
build without noticing.  This could be done for gerrit build verification (but 
this might add a lot of overhead and dealy to all our bilds).  So maybe a 
compromise is to test master on a nightly basis if it still builds in that 
environment.  If not, we'd at least get notification e-mails.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia8d5f4bb6570b5e055826f3a051e5e5896866e31
Gerrit-Change-Number: 41813
Gerrit-PatchSet: 5
Gerrit-Owner: Timur Davydov <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: Timur Davydov <[email protected]>
Gerrit-Comment-Date: Sun, 11 Jan 2026 21:38:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to