Attention is currently required from: Timur Davydov, laforge, neels, pespin.
fixeria has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email ) Change subject: Add Emscripten build support and JS callback logging backend ...................................................................... Patch Set 7: (4 comments) File src/core/osmo_io_internal.h: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/420d4965_3d83441b?usp=email : PS5, Line 7: HAVE_LIBSCTP > Thanks for catching this! […] Done File src/vty/logging_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/96a31399_f4270c3f?usp=email : PS5, Line 1130: > Thanks, fixed Done https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/d5804da1_0b1a4509?usp=email : PS5, Line 1361: install_lib_element(CONFIG_NODE, &cfg_log_web_cmd); : install_lib_element(CONFIG_NODE, &cfg_no_log_web_cmd); > Thanks — added conditional compilation `#if defined(__EMSCRIPTEN__)` Done File src/vty/telnet_interface_dummy.c: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/4e05164d_0c01dcff?usp=email : PS5, Line 18: #include <sys/socket.h> : #include <netinet/in.h> : #include <errno.h> : #include <stdlib.h> : #include <stdio.h> : #include <string.h> : #i > Thanks for pointing that out! […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia8d5f4bb6570b5e055826f3a051e5e5896866e31 Gerrit-Change-Number: 41813 Gerrit-PatchSet: 7 Gerrit-Owner: Timur Davydov <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: Timur Davydov <[email protected]> Gerrit-Comment-Date: Tue, 13 Jan 2026 08:39:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Comment-In-Reply-To: Timur Davydov <[email protected]>
