Attention is currently required from: osmith, pespin.

fixeria has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/41773?usp=email )

Change subject: ipaccess-config-e1-driver: Make sure struct input_signal_data 
is zero initialized
......................................................................


Patch Set 1:

(1 comment)

Commit Message:

https://gerrit.osmocom.org/c/osmo-bsc/+/41773/comment/369451dc_1d02a81f?usp=email
 :
PS1, Line 7: struct input_signal_data is zero initialized
What's the goal of doing that? Keep in mind that only the actual struct fields 
are initialized when using designated initializers, but not padding. So 
ASAN/UBSAN may still complain when `memcpy()ing` this structure.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41773?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If97c4a4202eaf96446d48e821d5e59c98bafe51c
Gerrit-Change-Number: 41773
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: jolly <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Mon, 12 Jan 2026 12:31:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to