Attention is currently required from: fixeria, osmith.

pespin has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/41773?usp=email )

Change subject: ipaccess-config-e1-driver: Make sure struct input_signal_data 
is zero initialized
......................................................................


Patch Set 1:

(1 comment)

Commit Message:

https://gerrit.osmocom.org/c/osmo-bsc/+/41773/comment/978a23ce_d556a6b2?usp=email
 :
PS1, Line 7: struct input_signal_data is zero initialized
> What's the goal of doing that? Keep in mind that only the actual struct 
> fields are initialized when  […]
I spotted this while looking at a libosmo-abis patch from @[email protected] 
which was aiming at adding new fields to that address (I don't have the patch 
link at hand, maybe Andreas can provide since it shows up in his UI).



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41773?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If97c4a4202eaf96446d48e821d5e59c98bafe51c
Gerrit-Change-Number: 41773
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: jolly <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Mon, 12 Jan 2026 12:43:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>

Reply via email to