Attention is currently required from: daniel, fixeria, laforge, osmith.

pespin has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41842?usp=email )

Change subject: logging: Improve GSMTAP log documentation
......................................................................


Patch Set 2:

(1 comment)

File common/chapters/logging.adoc:

https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41842/comment/50a4023b_b1600bde?usp=email
 :
PS2, Line 239:
> I just tested it with osmo-mgw and it works as described in the section you 
> have deleted: […]
Ah yes I read it to quickly, I thought it meant logging to gsmtap also meant 
logging to stderr. In any case, IMHO it is kind of obvios that you configure 
each log target independently, and then this kind of announce should be put in 
each other log target section. So I think it's best to drop it. The "force-all" 
stuff is already covered further above in the file.



--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41842?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I9434939d2a9a41bb0011a067f5ff9b94752fa781
Gerrit-Change-Number: 41842
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: daniel <[email protected]>
Gerrit-Comment-Date: Thu, 15 Jan 2026 10:50:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <[email protected]>

Reply via email to