Attention is currently required from: daniel, fixeria, laforge, pespin.

osmith has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41842?usp=email )

Change subject: logging: Improve GSMTAP log documentation
......................................................................


Patch Set 2:

(7 comments)

File common/chapters/logging.adoc:

https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41842/comment/6171dacd_4ef7a169?usp=email
 :
PS2, Line 239:
I just tested it with osmo-mgw and it works as described in the section you 
have deleted:
* when starting with either the default config or the default config with no 
`log` section, it logs to stderr by default (in both cases)
* `logging level force-all fatal` works to set the log output to a minimum


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41842/comment/e9f3bbf9_13e4b1d1?usp=email
 :
PS2, Line 233: syncrhonous
```suggestion
        the GSMTAP source socket as non-blocking, and attempt synchronous write
```


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41842/comment/67f68f40_6221472b?usp=email
 :
PS2, Line 238:  blocking mode, and attempt syncrhonous write to the UDP socket, 
blocking
```suggestion
        blocking mode, and attempt synchronous write to the UDP socket, blocking
```


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41842/comment/ddf6c631_171f025d?usp=email
 :
PS2, Line 242:  the thread for an un specified (potentially long or event 
infinite)
```suggestion
        the thread for an un specified (potentially long or even infinite)
```


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41842/comment/76c8b211_a372948e?usp=email
 :
PS2, Line 250: asyncrhonous
```suggestion
        GSMTAP source socket as non-blocking, and attempt asynchronous write to
```


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41842/comment/eb5a46e2_ba2a0def?usp=email
 :
PS2, Line 255: , messages
```suggestion
        buffer *and* the GSMTAP log target workqueue are full. This
```


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41842/comment/77c9ae91_08e897c3?usp=email
 :
PS2, Line 260: mode
```suggestion
In any of the I/O modes above, the UDP socket send buffer size of the GSMTAP log
```



--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41842?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I9434939d2a9a41bb0011a067f5ff9b94752fa781
Gerrit-Change-Number: 41842
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: daniel <[email protected]>
Gerrit-Comment-Date: Thu, 15 Jan 2026 09:31:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to