Attention is currently required from: daniel, osmith, pespin.

fixeria has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/libosmocore/+/41865?usp=email )

Change subject: gmstap_log: optimization: Add talloc_pool for transmitted 
messages
......................................................................


Patch Set 4: -Code-Review

(1 comment)

File src/core/logging_gsmtap.c:

https://gerrit.osmocom.org/c/libosmocore/+/41865/comment/0e7e2418_c5e10bbf?usp=email
 :
PS4, Line 77: msgb_alloc_c
> Well, embedded does not always imply pseudotalloc. […]
And BTW, osmo-ccid-firmware is a good example using talloc: 
`--host=arm-none-eabi --enable-embedded ... --disable-pseudotalloc`.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41865?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I19cdf09f21d856e8e3646de495ce7ae040195268
Gerrit-Change-Number: 41865
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: daniel <[email protected]>
Gerrit-Comment-Date: Sun, 18 Jan 2026 12:39:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>

Reply via email to