Attention is currently required from: daniel, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41865?usp=email )
Change subject: gmstap_log: optimization: Add talloc_pool for transmitted messages ...................................................................... Patch Set 5: (3 comments) File src/core/logging_gsmtap.c: https://gerrit.osmocom.org/c/libosmocore/+/41865/comment/264efcc3_aaa73842?usp=email : PS5, Line 171: sutrct struct https://gerrit.osmocom.org/c/libosmocore/+/41865/comment/7b66e8ab_7f6b7e0b?usp=email : PS5, Line 178: target->output = tall_msgb_ctx; `target->output` gets set in this patch. But where will it get used, maybe explain in the commit message? https://gerrit.osmocom.org/c/libosmocore/+/41865/comment/eb98031d_0be031c4?usp=email : PS5, Line 179: #endif /* ifndef EMBEDDED */ ```suggestion #endif /* ifndef PSEUDO_TALLOC */ ``` -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41865?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I19cdf09f21d856e8e3646de495ce7ae040195268 Gerrit-Change-Number: 41865 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: daniel <[email protected]> Gerrit-Comment-Date: Mon, 19 Jan 2026 09:09:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
