Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41874?usp=email )
Change subject: esim/http_json_api: extend JSON API with server functionality ...................................................................... Patch Set 1: Code-Review+1 (3 comments) Commit Message: https://gerrit.osmocom.org/c/pysim/+/41874/comment/a2130702_24bbd46b?usp=email : PS1, Line 17: tread treat https://gerrit.osmocom.org/c/pysim/+/41874/comment/4d19d320_0a8193a1?usp=email : PS1, Line 27: the tread "to treat the header"? Not sure what you mean File pySim/esim/es2p.py: https://gerrit.osmocom.org/c/pysim/+/41874/comment/14a1601f_2704f52e?usp=email : PS1, Line 252: The API user is expected to override wouldn't it be better to have an abc.ABC here? that way, the code woul fail to start if anyone ever did not override all the methods. But I guess here you actually want to permit users who do not override all the methods? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41874?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I277aa90fddb5171c4bf6c3436259aa371d30d092 Gerrit-Change-Number: 41874 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Tue, 20 Jan 2026 09:22:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
