Attention is currently required from: laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41874?usp=email )
Change subject: esim/http_json_api: extend JSON API with server functionality ...................................................................... Patch Set 2: (3 comments) Commit Message: https://gerrit.osmocom.org/c/pysim/+/41874/comment/b413bf5d_165a5e1f?usp=email : PS1, Line 17: tread > treat Done https://gerrit.osmocom.org/c/pysim/+/41874/comment/dfd56789_3fb07f7c?usp=email : PS1, Line 27: the tread > "to treat the header"? Not sure what you mean Done File pySim/esim/es2p.py: https://gerrit.osmocom.org/c/pysim/+/41874/comment/7ad11e30_61cdff78?usp=email : PS1, Line 252: The API user is expected to override > wouldn't it be better to have an abc. […] My original idea is that that the APU user only overrides the methods he needs. The other methods then would still exist, but requests would return Failed. I have thought a bit about this and now I think that an approach with abstract classes is indeed better since it is more specific. The SMDP+ side should always implement all methods expect the one for call_handleDownloadProgressInfo and on the MNO side we should see call_handleDownloadProgressInfo as the only method. The class model now reflects that. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41874?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I277aa90fddb5171c4bf6c3436259aa371d30d092 Gerrit-Change-Number: 41874 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Thu, 22 Jan 2026 17:53:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]>
