Attention is currently required from: Timur Davydov, pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email )
Change subject: build: keep netns API public and gate features with HAVE_* ...................................................................... Patch Set 8: (1 comment) File src/core/netns.c: https://gerrit.osmocom.org/c/libosmocore/+/41878/comment/e4fc1382_e69a4571?usp=email : PS7, Line 92: return -ENOSYS; > I'll change the fallback return code to -ENOTSUP and also add proper […] While looking into this, I also noticed that netns.c does not actually use anything from <sys/types.h>, <sys/stat.h> or <sys/socket.h>, and that <errno.h> is included twice. These includes appear to be leftovers. I can drop the unused headers as part of this change (or in a follow-up cleanup patch, if you prefer). -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2322eb2936bea35596f1fd6b6a713ea5f997b1ea Gerrit-Change-Number: 41878 Gerrit-PatchSet: 8 Gerrit-Owner: Timur Davydov <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: Timur Davydov <[email protected]> Gerrit-Comment-Date: Thu, 22 Jan 2026 16:06:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: Timur Davydov <[email protected]>
