Attention is currently required from: Timur Davydov, pespin.

laforge has posted comments on this change by Timur Davydov. ( 
https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email )

Change subject: build: keep netns API public and gate features with HAVE_*
......................................................................


Patch Set 8:

(1 comment)

File src/core/netns.c:

https://gerrit.osmocom.org/c/libosmocore/+/41878/comment/b2f09896_d5f0f099?usp=email
 :
PS7, Line 92:   return -ENOSYS;
> While looking into this, I also noticed that netns.c does not actually use […]
unrelated cleanup patches should be a separate patch. I personally would do it 
before introducing other changes (and I see othes in the osmocom developer 
community doing it that way, too)  But it's also acceptable to do it afterwards.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2322eb2936bea35596f1fd6b6a713ea5f997b1ea
Gerrit-Change-Number: 41878
Gerrit-PatchSet: 8
Gerrit-Owner: Timur Davydov <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: Timur Davydov <[email protected]>
Gerrit-Comment-Date: Thu, 22 Jan 2026 16:27:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Comment-In-Reply-To: Timur Davydov <[email protected]>

Reply via email to