Attention is currently required from: pespin.

Timur Davydov has posted comments on this change by Timur Davydov. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email )

Change subject: fix(threads): centralize portable strerror handling
......................................................................


Patch Set 2:

(2 comments)

File CommonLibs/Threads.cpp:

https://gerrit.osmocom.org/c/osmo-trx/+/42199/comment/83120942_26201f44?usp=email
 :
PS1, Line 58:         char *err_str = NULL;
> wrong indentation
Fixed


https://gerrit.osmocom.org/c/osmo-trx/+/42199/comment/448b737d_ea687898?usp=email
 :
PS1, Line 59: #if defined(__GLIBC__) && defined(_GNU_SOURCE)
> Can we move all this into a helper function above so it can be reused? […]
I’ve moved this into Utils as a reusable strerror_buf() helper and added a C++ 
wrapper strerror_str() based on std::error_code.



--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I642aff8a9f98823e117c4debd19384ddf5975039
Gerrit-Change-Number: 42199
Gerrit-PatchSet: 2
Gerrit-Owner: Timur Davydov <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Wed, 25 Feb 2026 16:37:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>

Reply via email to