Attention is currently required from: pespin.

Timur Davydov has posted comments on this change by Timur Davydov. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email )

Change subject: fix(threads): centralize portable strerror handling
......................................................................


Patch Set 3:

(1 comment)

File CommonLibs/Utils.cpp:

https://gerrit.osmocom.org/c/osmo-trx/+/42199/comment/74111118_5e7b1342?usp=email
 :
PS2, Line 36:
> So now you are adding a function which is not used anywhere?I'd rather drop 
> the c++ one and simply u […]
Yes, agreed. I dropped the C++ wrapper and kept only the C helper 
`strerror_buf()`. I also found a few remaining direct `strerror_r()` calls in 
`trx_rate_ctr.cpp` and `IPCDevice.cpp` — do you want me to switch those to 
`strerror_buf()` as well to keep error handling consistent across the codebase?



--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I642aff8a9f98823e117c4debd19384ddf5975039
Gerrit-Change-Number: 42199
Gerrit-PatchSet: 3
Gerrit-Owner: Timur Davydov <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Wed, 25 Feb 2026 19:20:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>

Reply via email to