Attention is currently required from: Hoernchen, laforge. pespin has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/libosmocore/+/42203?usp=email )
Change subject: fix --disable-log-macros ...................................................................... Patch Set 3: (1 comment) File configure.ac: https://gerrit.osmocom.org/c/libosmocore/+/42203/comment/44212f2a_a8d6b4b6?usp=email : PS1, Line 511: if test x"$log_macros" == x"yes" > My first attempt is actually the only sane way to do it unless you want to > somehow "invert" the yes/ […] https://www.gnu.org/software/autoconf/manual/autoconf-2.66/html_node/Package-Options.html When using log_macros=$enableval: * If user passes --enable-log-macro: log_macros="yes" * If user passes --disable-log-macro: log_macros="no" * If used passes nothing, the default is applied, ie. "log_macros=$ENABLE_LIBOSMOCORE_NO_LOGGING_DEFAULT])" which is ENABLE_LIBOSMOCORE_NO_LOGGING_DEFAULT="no", so log_macros="no". The double negation thing, which makes everything too complex and wrong. The problem is actually that when user passing nothing, it ends up with log_macros="no", which should be actually log_macros="yes", because we want to enable log macros by default. So, my proposal: * Rename ENABLE_LIBOSMOCORE_NO_LOGGING_DEFAULT to ENABLE_LOG_MACROS_DEFAULT * Set ENABLE_LOG_MACROS_DEFAULT="yes" by default in line 244 * Set ENABLE_LOG_MACROS_DEFAULT="no" inside the `if test x"$embedded" = x"yes"` block in line 262 (because I understand that we want logging macros disabled by default when in EMBEDDED, otherwise skip this step) * Change the `if test x"$log_macros" == x"yes"` condition in line 511 as mentioned in my previous comment. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42203?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I809ab2f61e72428ba21061055296eb83d6d710ab Gerrit-Change-Number: 42203 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: Hoernchen <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Wed, 25 Feb 2026 16:47:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <[email protected]> Comment-In-Reply-To: pespin <[email protected]>
